patsonluk commented on PR #2913:
URL: https://github.com/apache/solr/pull/2913#issuecomment-2561336393
> @patsonluk do you know about this? **If** there's a problem, it's
HttpShardHandler (the only caller) who passes this cloudDescriptor on to
`org.apache.solr.handler.component.HttpShardHandler#canShortCircuit` which we
want to return false for any coordinator. Maybe it will do so _anyway_. If we
want to guarantee it, we could modify this code to recognize the coordinator
somehow.
I am unfamiliar with the short circuit logic but based on debugging if we
stop using `_` as shard id in `CloudDescriptor` (as in this PR), then
`canShortCircuit` would return true. Not totally sure about the implication but
`rb.shortCircuitedURL =
ZkCoreNodeProps.getCoreUrl(zkController.getBaseUrl(),
coreDescriptor.getName());` will be executed and a short circuited URL will be
used? which seems incorrect since the coordinator node does not actually host
the shard?
Sorry I'm really helping much here 😓 , however to play safe, we might want
to keep returning `false` for canShortCircuit calls done on Cooridnator node
as you proposed (ie modify this code to recognize the coordinator somehow)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
