dsmiley commented on code in PR #2913:
URL: https://github.com/apache/solr/pull/2913#discussion_r1896868578
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -160,28 +156,13 @@ protected String getCoreOrColName() {
return collectionName;
}
- public static SolrQueryRequest wrappedReq(
- SolrQueryRequest delegate, String collectionName, HttpSolrCall
httpSolrCall) {
- Properties p = new Properties();
- if (collectionName != null) {
- p.put(CoreDescriptor.CORE_COLLECTION, collectionName);
- }
- p.put(CloudDescriptor.REPLICA_TYPE, Replica.Type.PULL.toString());
- p.put(CoreDescriptor.CORE_SHARD, "_");
+ public static SolrQueryRequest wrappedReq(SolrQueryRequest delegate,
HttpSolrCall httpSolrCall) {
Review Comment:
Yup, that's what's happening and the rationale.
It would be hard to prevent this as most handler and related things like
SearchComponents can be "SolrCoreAware" or otherwise manage to get access to
the SolrCore via SolrQueryRequest.getCore. That said, I think it'd be unusual
for a handler or SearchComponent to do something erroneously with this access
when in the coordinator mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
