mlbiscoc commented on code in PR #3745:
URL: https://github.com/apache/solr/pull/3745#discussion_r2421937571
##########
solr/core/src/test/org/apache/solr/handler/admin/AdminHandlersProxyTest.java:
##########
@@ -71,7 +71,9 @@ public void proxySystemInfoHandlerAllNodes() throws
IOException, SolrServerExcep
assertEquals(nl.getName(2), ((NamedList)
nl.get(nl.getName(2))).get("node"));
}
+ // NOCOMMIT: The nodes view might be broken because of this
@Test
+ @AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-8207";)
public void proxyMetricsHandlerAllNodes() throws IOException,
SolrServerException {
Review Comment:
So I was looking at this and the UI and it's not broken? I am not good at
Solr JS admin ui but I don't think it was using /admin/metrics for this but
instead /admin/info/system handler. Turns out I also fixed that node view when
I committed
[7daafff](https://github.com/apache/solr/pull/3745/commits/7daafffdde05adb321097ed16d9faff492e18bb0)
going back and forth between the commits basically killing two birds with one
stone. I am thinking of removing this test if no objections unless I am missing
something here I don't know about the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
