dsmiley commented on PR #3745: URL: https://github.com/apache/solr/pull/3745#issuecomment-3449232240
I think `SolrMetricsContext.getChildContext` might need a little attention. It's `child` arg isn't used anymore. Harmless; it might be used later if we want. Perhaps SolrMetricsContext once held a reference to the thing it's tied to but doesn't any longer? I suppose its javadocs are mostly valid. Somewhat related, I see closeables are closed in an `unregister()` method, called by 4 places. I think it'd be clearer if this method was named closed(), and SolrMetricsContext implemented AutoCloseable, and maybe even ObjectReleaseTracker could help us detect when we forget to close (to thwart memory leaks). I'd be happy to do what I suggest; just wanted to discuss with you. If I do the ObjectReleaseTracker thing; the other JIRA about memory leaks would be a suitable issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
