mlbiscoc commented on code in PR #3745:
URL: https://github.com/apache/solr/pull/3745#discussion_r2420848013
##########
gradle/libs.versions.toml:
##########
@@ -320,11 +320,7 @@ cybozulabs-langdetect = { module =
"com.cybozu.labs:langdetect", version.ref = "
decompose-decompose = { module = "com.arkivanov.decompose:decompose",
version.ref = "decompose" }
decompose-extensions-compose = { module =
"com.arkivanov.decompose:extensions-compose", version.ref = "decompose" }
dropwizard-metrics-core = { module = "io.dropwizard.metrics:metrics-core",
version.ref = "dropwizard-metrics" }
Review Comment:
Forgot to mention this. I didn't remove it completely because a few things
were using the instruments but not necessarily the registry for the metrics
collection beside `CrossDcConsumer` (I don't know much about this module).
1.
[Stats](https://github.com/apache/solr/blob/20d810785c1ac68856fd15561fe0e3d614816117/solr/core/src/java/org/apache/solr/cloud/Stats.java#L123)
was being used for overseer and Zk distributed queue and this was also being
used by embedded zk metrics. It worked with the `OverseerStatusCmd` API to just
get some averages and rates from the instruments.
2.
[MiniClusterState](https://github.com/apache/solr/blob/20d810785c1ac68856fd15561fe0e3d614816117/solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java#L472)
was using the meter instrument for logging somethings
3.
[CrossDcConsumer](https://github.com/apache/solr/blob/20d810785c1ac68856fd15561fe0e3d614816117/solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/KafkaCrossDcConsumer.java#L76)
was creating its own registry it looks like for collecting metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
