dsmiley commented on code in PR #3829:
URL: https://github.com/apache/solr/pull/3829#discussion_r2500454379
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##########
Review Comment:
good observation; yes I think this test is specific to Apache HttpClient, so
it should be renamed (or not), moved, and eventually removed. We have other
tests naming the other clients and their names; ideally this one would have
been renamed when those came into being.
##########
solr/test-framework/src/java/org/apache/solr/client/solrj/apache/SolrPortAwareCookieSpecFactory.java:
##########
@@ -31,6 +31,7 @@
import org.apache.http.protocol.HttpContext;
@SuppressWarnings("deprecation")
+@Deprecated
Review Comment:
Yes; notice the package name.
This really underscores to me why our different implementations ought to get
their very own packages!
##########
changelog/unreleased/SOLR-17968-HttpSolrClient.yml:
##########
@@ -0,0 +1,8 @@
+
+title: Introduce org.apache.solr.client.solrj.HttpSolrClient, implemented by
the Jetty & JDK HttpClient based SolrClients.
Review Comment:
HttpApacheSolrClient has a death sentence; I don't want to speak of it more
than necessary.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/HttpSolrClient.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj;
+
+/** A {@link SolrClient} based on HTTP. */
Review Comment:
great idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
