dsmiley opened a new pull request, #4119: URL: https://github.com/apache/solr/pull/4119
https://issues.apache.org/jira/browse/SOLR-18112 Also, optimized the configuration of excludePatterns to leverage the regular expression nature it supported but we weren't using. Nonetheless, to me, PathExclusionFilter seems pointless when we could directly map these paths to the "default" servlet. I'm very tempted to, in this PR, also change the configuration of the new filters to directly reference the servlet instead of using a `/*` pattern. This separates them from other servlets that might be registered, e.g. in tests where DebugServlet etc. are used. I think `CoreContainerAwareHttpFilter` should be eliminated in lieu of calling `CoreContainerProvider.serviceForContext(config.getServletContext());`. Surely that's easy enough to not require a parent class. (classes can only have one parent class so lets not use one for trivial reasons). The Servlet couldn't extend that special Filter, for example. Not sure if that should be in this PR. The first commit/iteration of this PR doesn't rename SolrDispatchFilter to SolrFilter. Maybe leave that for a 2nd PR, same issue. Is this a backwards compatibility concern? Um... probably not. We're changing so much with the filters/servlet SDF that we might as well do it in 10.x. It's "internal" anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
