dsmiley commented on code in PR #4119:
URL: https://github.com/apache/solr/pull/4119#discussion_r2785920743
##########
solr/webapp/web/WEB-INF/web.xml:
##########
@@ -29,13 +29,13 @@
<filter-name>PathExclusionsFilter</filter-name>
<filter-class>org.apache.solr.servlet.PathExclusionFilter</filter-class>
<!--
- Exclude patterns is a list of directories that would be short-circuited by
this
- Filter. It includes all Admin UI related static content.
- NOTE: It is NOT a pattern but only matches the start of the HTTP
ServletPath.
+ Requests with URL paths matching these patterns will be redirected to the
"default" servlet.
+ It includes all Admin UI related static content.
+ Syntax: comma delimited regular expressions, and only need to match the
start of the path.
Review Comment:
Sure. Albeit I probably wasted time bothering with this this tiny
optimization and touching the docs since I'm confident I can remove
PathExclusionFilter after this merges in a follow-up PR. Granted it will be a
good deal more configuration here but simple and no more custom Java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
