malliaridis commented on PR #4119: URL: https://github.com/apache/solr/pull/4119#issuecomment-3872765277
This PR would break the new UI button reference, since the new UI is accessible at http://127.0.0.18983/solr/ui/ and the updated regex does not cover it I believe. The new UI is still accessible by opening http://127.0.0.18983/solr/ui/index.html, but updating the button link would break any path the new UI plans to use (e.g. for deep links or reloading page at specific sub-pages, like `solr/ui/collections`). Does it make sense to still include the wildcard `ui/*` path so that it continues to work? Or are there any better approaches to include the new UI perhaps that should be considered? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
