dsmiley commented on code in PR #4226: URL: https://github.com/apache/solr/pull/4226#discussion_r2954379882
########## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ########## @@ -94,7 +94,7 @@ public class SearchHandler extends RequestHandlerBase private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); - private HandlerMetrics metricsShard = HandlerMetrics.NO_OP; + private HandlerMetrics metricsShard; // nocommit NO_OP Review Comment: I'm more convinced than ever that the NO_OP was a bad move. It was making problems that should have been root-caused. Handlers cannot be used until they have been initialized (including metrics). A follow-up commit here will show that InfoHandler was creating sub-handlers and not fully initializing them, thus any metrics such sub-handlers wanted to create were not getting closed. PublicKeyHandler seems affected as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
