dsmiley commented on code in PR #4226:
URL: https://github.com/apache/solr/pull/4226#discussion_r2962764428
##########
solr/core/src/java/org/apache/solr/handler/SchemaHandler.java:
##########
@@ -305,10 +308,28 @@ public Category getCategory() {
return Category.ADMIN;
}
+ @Override
+ public void initializeMetrics(SolrMetricsContext parentContext, Attributes
attributes) {
+ // Store parent context so we can use it in inform() to initialize
sub-handlers as siblings
Review Comment:
Totally agree! Worth a JIRA IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
