dsmiley commented on code in PR #4226:
URL: https://github.com/apache/solr/pull/4226#discussion_r2960067182
##########
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##########
@@ -139,7 +139,7 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
coreAdminAsyncTracker.expensiveExecutor =
solrMetricsContext.instrumentedExecutorService(
coreAdminAsyncTracker.expensiveExecutor,
- "solr_node_executor",
+ "solr_node_expensive_executor",
Review Comment:
ah; a fix
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -1129,8 +1128,8 @@ protected SolrCore(
SolrFieldCacheBean solrFieldCacheBean = new SolrFieldCacheBean();
// this is registered at the CONTAINER level because it's not
core-specific - for now we
// also register it here for back-compat
Review Comment:
back-compat -- we should remove in 10.1 if I remember
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
Review Comment:
BTW I really appreciate the improvements here @HoustonPutman :-)
##########
solr/core/src/java/org/apache/solr/handler/SchemaHandler.java:
##########
@@ -305,10 +308,28 @@ public Category getCategory() {
return Category.ADMIN;
}
+ @Override
+ public void initializeMetrics(SolrMetricsContext parentContext, Attributes
attributes) {
+ // Store parent context so we can use it in inform() to initialize
sub-handlers as siblings
Review Comment:
I wish inform() calls happened before initializeMetrics... but that's
another issue and isn't easy
##########
solr/core/src/java/org/apache/solr/handler/admin/InfoHandler.java:
##########
Review Comment:
InfoHandler has sub-handlers, and must tend to their lifecycle, including
metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
