epugh commented on code in PR #4203: URL: https://github.com/apache/solr/pull/4203#discussion_r3211590286
########## solr/packaging/test/test_schema_designer.bats: ########## @@ -0,0 +1,181 @@ +#!/usr/bin/env bats Review Comment: I pruned it back a lot... I think my thought on BATS is that it would cover the "we call multiple apis" use case.. But honestly, schema designer isnt' really something i care a lot about, and I can totally see removing this. I first wrote the bats test just to try and udnerstand the sequence of api calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
