gerlowskija commented on code in PR #4203: URL: https://github.com/apache/solr/pull/4203#discussion_r3212074440
########## solr/packaging/test/test_schema_designer.bats: ########## @@ -0,0 +1,181 @@ +#!/usr/bin/env bats Review Comment: It'd be nice to have some sort of documented "best practice" for when something gets unit tests, when it gets integration tests, when it gets BATS, etc. I think the unit/integration thing is a bit looser, but especially given the runtime of the BATS stuff it'd be nice to have clear consensus on. Anyway, thanks for reconsidering! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
