epugh commented on code in PR #4203:
URL: https://github.com/apache/solr/pull/4203#discussion_r3211907687
##########
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesigner.java:
##########
@@ -1273,7 +1360,40 @@ protected void addSettingsToResponse(
}
}
- protected String checkMutable(String configSet, SolrQueryRequest req) throws
IOException {
+ void addSettingsToResponse(
+ SchemaDesignerSettings settings, final SchemaDesignerInfoResponse
response) {
+ response.languages = settings.getLanguages();
Review Comment:
Nice call.. I dug in and discovered that we actually had four emthods and
one wasn't even used.. Refactored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
