vyatkinv commented on PR #4320: URL: https://github.com/apache/solr/pull/4320#issuecomment-4462261953
Maybe it would make sense to split `SolrClientCache` implementations: one for the client library and another one for internal server-side usage. Right now `SolrClientCache` already contains `defaultZkHost` handling and `canUseACLs` checks. With the new changes we are also adding another predicate and logic for determining whether a client belongs to the local cluster. One possible approach could be to extract a common interface, for example `SolrClientProvider`. Then `SolrClientCache` could be simplified and remain focused on client-side concerns only, while a second `SolrClientProvider` implementation could be introduced for internal Solr usage, handling `canUseACLs`, trusted/whitelisted hosts, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
