vyatkinv commented on PR #4320: URL: https://github.com/apache/solr/pull/4320#issuecomment-4467439679
I've addressed the previous review comments, split the changelog entries, and introduced `InternalSolrClientCache`. I also removed the server-side protection logic from `SolrClientCache` and moved it into `InternalSolrClientCache`, so the restrictions are now applied only to internal/server-side usages. Additionally, I expect some clients may need to connect to ZooKeeper ACL-protected clusters via the solrj-streaming module, so I added `setUseZookeeperACL()` to `SolrClientCache`. It is disabled by default for security reasons. I didn't notice at first that there are also integration tests for running CLI utilities (*.bats). Do I need to add tests for the `--solr-connection` parameter there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
