heitzjm opened a new pull request, #4474:
URL: https://github.com/apache/solr/pull/4474

   https://issues.apache.org/jira/browse/SOLR-18270
   
   
   # Description
   
   This PR only update the request attribute used by CertAuthPlugin to match 
the one filled by Jetty 12 - for SOLR 10. SOLR 9 works fine in the Official 
Docker Image, as it uses a lower major Jetty version, so it should only be 
merged in Solr 10 branches (other PR with parametrization that should be 
suitable for both SOLR 9 and 10 coming).
   
   # Solution
   
   This PR only update the request attribute used by CertAuthPlugin to match 
the one filled by Jetty 12 - for SOLR 10. 
   
   # Tests
   
   I checked locally by compiling SOLR from source, as well as building Docker 
Image from source and tested it in a K8S environment.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ x ] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [ x ] I have created a Jira issue and added the issue ID to my pull 
request title.
   - [ x ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [ x ] I have developed this patch against the `main` branch.
   - [ x ] I have run `./gradlew check`.
   5582 tests completed, 1 failed, 184 skipped
   ERROR: The following test(s) have failed:
     - 
org.apache.solr.handler.component.AsyncTrackerSemaphoreLeakTest.testSemaphoreLeakOnLBRetry
 (:solr:core)
   => however, in my opinion, this test does not seem to be relevant for this PR
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [ x ] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   unreleased/SOLR-18270-easy-fix-without-parametrization.yml
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to