laminelam commented on code in PR #4474:
URL: https://github.com/apache/solr/pull/4474#discussion_r3589838102
##########
solr/core/src/java/org/apache/solr/security/CertAuthPlugin.java:
##########
@@ -102,7 +104,10 @@ public boolean doAuthenticate(
HttpServletRequest request, HttpServletResponse response, FilterChain
filterChain)
throws Exception {
X509Certificate[] certs =
- (X509Certificate[])
request.getAttribute("javax.servlet.request.X509Certificate");
+ (X509Certificate[])
request.getAttribute(CURRENT_REQUEST_ATTRIBUTE_NAME);
+ if (certs == null || certs.length == 0) {
+ certs=(X509Certificate[])
request.getAttribute(OLD_REQUEST_ATTRIBUTE_NAME);
Review Comment:
You may want to rename the variables to something meaningful, how about:
_JAVAX_REQUEST_ATTRIBUTE_NAME_
_JAKARTA_REQUEST_ATTRIBUTE_NAME_ ?
Also, you will need to run spotless check, you're missing some white spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
