heitzjm commented on code in PR #4474:
URL: https://github.com/apache/solr/pull/4474#discussion_r3589474303
##########
solr/core/src/java/org/apache/solr/security/CertAuthPlugin.java:
##########
@@ -102,7 +104,10 @@ public boolean doAuthenticate(
HttpServletRequest request, HttpServletResponse response, FilterChain
filterChain)
throws Exception {
X509Certificate[] certs =
- (X509Certificate[])
request.getAttribute("javax.servlet.request.X509Certificate");
+ (X509Certificate[])
request.getAttribute(CURRENT_REQUEST_ATTRIBUTE_NAME);
+ if (certs == null || certs.length == 0) {
+ certs=(X509Certificate[])
request.getAttribute(OLD_REQUEST_ATTRIBUTE_NAME);
Review Comment:
I think both should stay - in my understanding, SOLR, at its basis, is a web
application that could run in other java web application servers than the Jetty
provided in the Docker image - so I think it would be better to keep both names
to ease integration. This way, this PR might even be merged to SOLR 9 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
