dsmiley commented on code in PR #4632:
URL: https://github.com/apache/solr/pull/4632#discussion_r3566874715
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java:
##########
@@ -574,16 +575,14 @@ public void handleError(Throwable ex) {
}
/**
- * Called when an error occurs sending a batch, with the {@link Update} that
failed. The default
- * implementation invokes the {@link UpdateErrorHandler} registered via
{@link
- * Builder#withErrorHandler} if one was provided (passing the failed request
and its documents),
- * and otherwise falls back to {@link #handleError(Throwable)}. Subclasses
may still override this
- * to recover the documents that did not reach the server. See SOLR-3284.
+ * Internal dispatch for a failed batch: if an {@link UpdateErrorHandler}
was registered via
+ * {@link Builder#withErrorHandler} it is invoked with the failed request
and its documents,
+ * otherwise we fall back to {@link #handleError(Throwable)}.
*
* @param ex the error that occurred
* @param update the update (request + collection) that failed to send; may
be null
*/
Review Comment:
so much words for a private method that reads plainly in fewer. Please
remove.
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateJdkSolrClientTest.java:
##########
Review Comment:
as the changes in this PR are not strictly related to JDK HttpClient,
couldn't you put this test in ConcurrentUpdateSolrClientTestBase instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
