serhiy-bzhezytskyy commented on PR #4632: URL: https://github.com/apache/solr/pull/4632#issuecomment-4958926373
Switched it to report the failed document ids instead of the requests — `onError(Throwable, List<String> ids, String collection)` — so only ids are retained, not the documents, preserving the streaming memory efficiency. The id comes from an overridable `extractId(SolrInputDocument)` defaulting to the `id` field, so a caller with a different uniqueKey can override it. When no handler is registered the documents are never read, so there's no overhead on the default path. On the Jetty side the ids are collected as each doc is streamed, so a coalesced batch still reports every affected id on failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
