dsmiley commented on code in PR #4632:
URL: https://github.com/apache/solr/pull/4632#discussion_r3571028669
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/ConcurrentUpdateJettySolrClient.java:
##########
@@ -104,6 +105,8 @@ private static class OutStream implements Closeable {
private final OutputStreamRequestContent content;
private final InputStreamResponseListener responseListener;
private final boolean isXml;
+ // the updates coalesced into this stream, so a failure can report every
affected one
+ private final List<ConcurrentUpdateBaseSolrClient.Update> updates = new
ArrayList<>();
Review Comment:
hmm; I'm concerned that this error tracking feature is going to hurt a
benefit of CUSC -- memory efficiency (streaming a huge volume of updates).
What if we only track a designated ID field? The error handler could have a
customizable overrideable method, defaulting to return the "id" field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
