serhiy-bzhezytskyy commented on code in PR #4632:
URL: https://github.com/apache/solr/pull/4632#discussion_r3573814689


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java:
##########
@@ -187,6 +221,51 @@ protected ConcurrentUpdateBaseSolrClient(Builder builder) {
   /** Class representing an UpdateRequest and an optional collection. */
   protected record Update(UpdateRequest request, String collection) {}
 
+  /**
+   * The result of sending one or more updates as a single stream: the 
response to await, plus the
+   * ids of the documents actually sent and their collection. A transport may 
coalesce several
+   * queued updates into one stream (e.g. the Jetty client), so it reports the 
ids of all of them
+   * here -- letting the error handler learn every failed document, not just 
the first. Only ids are
+   * retained (see {@link UpdateErrorHandler#extractId}), preserving streaming 
memory efficiency;

Review Comment:
   Trimmed to what the method does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to