epugh commented on code in PR #4474:
URL: https://github.com/apache/solr/pull/4474#discussion_r3606466701
##########
solr/core/src/java/org/apache/solr/security/CertAuthPlugin.java:
##########
@@ -102,7 +106,10 @@ public boolean doAuthenticate(
HttpServletRequest request, HttpServletResponse response, FilterChain
filterChain)
throws Exception {
X509Certificate[] certs =
- (X509Certificate[])
request.getAttribute("javax.servlet.request.X509Certificate");
+ (X509Certificate[])
request.getAttribute(JAKARTA_REQUEST_ATTRIBUTE_NAME);
Review Comment:
I had a chat with @dsmiley today, and he confirmed that Solr is NOT ever
going to run in anything but Jetty, so we don't need to support that. Of
course, that doesn't apply to the embedded mode ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
