gerlowskija commented on code in PR #4474:
URL: https://github.com/apache/solr/pull/4474#discussion_r3606281645
##########
solr/core/src/java/org/apache/solr/security/CertAuthPlugin.java:
##########
@@ -102,7 +104,10 @@ public boolean doAuthenticate(
HttpServletRequest request, HttpServletResponse response, FilterChain
filterChain)
throws Exception {
X509Certificate[] certs =
- (X509Certificate[])
request.getAttribute("javax.servlet.request.X509Certificate");
+ (X509Certificate[])
request.getAttribute(CURRENT_REQUEST_ATTRIBUTE_NAME);
+ if (certs == null || certs.length == 0) {
+ certs=(X509Certificate[])
request.getAttribute(OLD_REQUEST_ATTRIBUTE_NAME);
Review Comment:
Maybe I'm wrong, but I don't know of anyone that's taking Solr and running
it in a different app server or even a different Jetty version than what Solr
ships with. Our code is really tightly coupled with Jetty to the point where I
doubt that sort of thing is even possible.
Ultimately it's a minor concern that's not worth holding up the PR, but the
odds are so small of someone doing this successfully that idk that the fallback
logic is worth it 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
