heitzjm commented on code in PR #4474:
URL: https://github.com/apache/solr/pull/4474#discussion_r3606236633
##########
solr/core/src/java/org/apache/solr/security/CertAuthPlugin.java:
##########
@@ -102,7 +106,10 @@ public boolean doAuthenticate(
HttpServletRequest request, HttpServletResponse response, FilterChain
filterChain)
throws Exception {
X509Certificate[] certs =
- (X509Certificate[])
request.getAttribute("javax.servlet.request.X509Certificate");
+ (X509Certificate[])
request.getAttribute(JAKARTA_REQUEST_ATTRIBUTE_NAME);
Review Comment:
I implemented the fallback logic because at the time of writing, I was still
thinking of Solr as of a web application running in a web application server
(that is, that could be distributed with a web application archive (`war`)
file). However, @epugh
<https://github.com/apache/solr/pull/4474#discussion_r3595384399> made me
notice Solr is no more distributed that way.
At least having the fallback could allow to merge the commit in both 9.x and
10.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
