janhoy commented on code in PR #50:
URL: https://github.com/apache/solr-orbit/pull/50#discussion_r3658606961
##########
Makefile:
##########
@@ -47,19 +33,15 @@ check-java:
echo "NOTE: Java version 17 required to have all integration tests
pass" >&2; \
fi
-install-deps: check-pip
- $(PIP) install --upgrade pip setuptools wheel
-
-develop: pyinst312 install-deps
- PIP_ONLY_BINARY=h5py $(PIP) install -e .[develop]
+develop: check-uv
+ UV_CONSTRAINT_BINARY=h5py uv sync --extra develop
Review Comment:
I cannot find documentation for either of these env variables, so this is
likely a no-op.
Discussing with AI, perhaps the same intent can be solved by editing
`pyproject.toml`:
```toml
[tool.uv]
no-build-package = ["h5py"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
