janhoy commented on code in PR #50:
URL: https://github.com/apache/solr-orbit/pull/50#discussion_r3659257520
##########
Makefile:
##########
@@ -70,33 +51,28 @@ python-caches-clean:
-@find . -name "__pycache__" -prune -exec rm -rf -- \{\} \;
-@find . -name ".pyc" -prune -exec rm -rf -- \{\} \;
-# Note: pip will not update project dependencies (specified in pyproject.toml)
if any version is
-# already installed; therefore we recommend recreating your environments
whenever your project
-# dependencies change.
tox-env-clean:
rm -rf .tox
-lint:
- ruff check .
- # ruff format --check . # uncomment once the codebase has been
formatted
+lint: develop
+ uv run ruff check .
+ # uv run ruff format --check . # uncomment once the codebase has been
formatted
test: develop
- pytest tests/
+ uv run pytest tests/
-it: pyinst check-java python-caches-clean tox-env-clean
- @tox --version 2>/dev/null | grep -qE '^[4-9]\.' || $(PIP) install
"tox>=4"
- tox
+it: check-uv check-java python-caches-clean tox-env-clean
+ uv run --extra develop tox
-it312 it313: pyinst check-java python-caches-clean tox-env-clean
- @tox --version 2>/dev/null | grep -qE '^[4-9]\.' || $(PIP) install
"tox>=4"
- tox -e $(@:it%=py%)
+it312 it313: check-uv check-java python-caches-clean tox-env-clean
+ uv run --extra develop tox -e $(@:it%=py%)
Review Comment:
Tox is no longer auto installed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]