janhoy commented on code in PR #50:
URL: https://github.com/apache/solr-orbit/pull/50#discussion_r3659302491
##########
Makefile:
##########
@@ -47,19 +32,15 @@ check-java:
echo "NOTE: Java version 17 required to have all integration tests
pass" >&2; \
fi
-install-deps: check-pip
- $(PIP) install --upgrade pip setuptools wheel
-
-develop: pyinst312 install-deps
- PIP_ONLY_BINARY=h5py $(PIP) install -e .[develop]
+develop: check-uv
+ uv sync --extra develop
-build: install-deps
- $(PIP) install --upgrade build
- $(PYTHON) -m build
+build: check-uv
+ uv build
# Builds a wheel from source, then installs it.
install: build
- PIP_ONLY_BINARY=h5py $(PIP) install dist/*.whl
+ uv pip install dist/*.whl
Review Comment:
Claude: uv pip install dist/*.whl. uv pip install needs a discoverable
environment (.venv/$VIRTUAL_ENV) or --system; install: build never creates one,
so on a fresh tree it errors with "No virtual environment found." When a .venv
does exist, it installs the wheel over the editable dev install rather than to
system/user site (the old behavior).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
