epugh opened a new pull request, #4679: URL: https://github.com/apache/solr/pull/4679
# Description Reviewing code in the org.apache.solr.metrics package for potential improvements. # Solution Mostly driven by what IntelliJ is suggesting are weaknesses. Specifically, there were quite a few unused methods and classes in the Metrics package. I debated removing them, so I kept them in a single commit to make it easy to undo it. I odn't know if having htose methods etc was for OTHER consumers of Solr? @mlbiscoc I'd love your opinon on this. # Tests I had to tweak them just a bit after editing. Otherwise just rerunning them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
