epugh commented on code in PR #4679: URL: https://github.com/apache/solr/pull/4679#discussion_r3694018537
########## solr/core/src/java/org/apache/solr/metrics/otel/instruments/AttributedDoubleCounter.java: ########## Review Comment: thanks for chiming in.. I worry about YAGNI, but also get the reasons for keeping it. I'll back out those changes, and then look to merge... Anything else that looks iffy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
