mlbiscoc commented on code in PR #4679: URL: https://github.com/apache/solr/pull/4679#discussion_r3685488185
########## solr/core/src/java/org/apache/solr/metrics/otel/instruments/AttributedDoubleCounter.java: ########## Review Comment: So for these instruments, I purposely created them as tools if someone wanted to capture metrics with these doubles in the future even though I didn't use them myself on the migration. All of our metrics back then I don't think did things with doubles and it was all longs but with OTEL we are not constrained to that anymore. I personally prefer to keep them for future developers so they know that these tools do exist. Or maybe an LLM sees these exist and decides this is the best instrument instead of the ones we used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
