dsmiley commented on code in PR #4652:
URL: https://github.com/apache/solr/pull/4652#discussion_r3679337047
##########
solr/core/src/java/org/apache/solr/search/DisMaxQParser.java:
##########
@@ -227,6 +227,9 @@ protected Query getPhraseQuery(String userQuery,
SolrPluginUtils.DisjunctionMaxQ
* matched those phrases but do match looser phrases.
*/
String userPhraseQuery = userQuery.replace("\"", "");
+ if (userPhraseQuery.isBlank() || userPhraseQuery.trim().indexOf(' ') < 0) {
Review Comment:
Seems slightly more efficient to trim the userPhraseQuery first, then
*don't* call isBlank; just check the length and check for a space char.
##########
changelog/unreleased/SOLR-18314-skip-phrase-analysis-single-term.yml:
##########
@@ -0,0 +1,8 @@
+title: Skip phrase field (pf) boost analysis for single-term queries in DisMax
and eDisMax parsers
Review Comment:
should clarify that this could result in scoring/relevancy changes, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
