dsmiley commented on code in PR #4652: URL: https://github.com/apache/solr/pull/4652#discussion_r3723048219
########## solr/core/src/java/org/apache/solr/search/DisMaxQParser.java: ########## Review Comment: 1. I don't get the problem. "so BQ clause count is really the number of whitespace-separated words, not analyzed terms. " -- so what? I think we indeed want to know the clause count of 'q' (i.e. BQ clause count) and don't care what the analyzed term shape looks like. If the query is `wi-fi` then this is one clause and will end up producing a PhraseQuery of "wi fi" because the non-whitespace span of characters implies positional adjacency to analyzed component terms. 2. "so the qf query's term count isn't a reliable proxy." I agree and didn't mean to imply using that. I only suggest examining the _clause count_ of the parsedUserQuery, which is loosely the number of whitespace separated parts. Technically, maybe not exactly this, since the query string may have syntax like quotes, thus the whitespace inside quoted parts don't count. But the parser accounts for that, emitting a BooleanQuery clause for each component, thus it'd just be a PhraseQuery if a user quoted their query already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
