janhoy opened a new pull request, #4684: URL: https://github.com/apache/solr/pull/4684
Adds picocli support to `AuthTool` following the established dual-path pattern: - Business logic extracted from the commons-cli-coupled `handleBasicAuth(CommandLine)` into `enableBasicAuth`/`disableBasicAuth` operating on a shared `AuthParams` record plus a pluggable zk-host resolver, so both parsing paths run identical code. - `@Command` annotation with examples and exit codes; `enable|disable` as a positional parameter; options mirror the commons-cli definitions, with connection/credentials options provided by the `ZkConnectionOptions` mixin (includes the new `-s/--solr-connection`). - `AuthTool` registered as a `SolrCLI` subcommand; generated `solr-auth.adoc` ref-guide page included. - `AuthToolPicocliTest` runs the whole existing `AuthToolTest` suite through `picocli.CommandLine.execute()`. Boolean-ish options (`--block-unknown` etc.) stay string-typed so both paths emit the same validation message asserted by `test_auth.bats`. Connection parsing remains string-only; no I/O happens during argument parsing. Verified: `AuthToolTest` + `AuthToolPicocliTest` green, `test_auth.bats` green on the commons-cli path and the picocli path (`SOLR_PICOCLI=true`), `check -x test` with Error Prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
