janhoy commented on code in PR #4684:
URL: https://github.com/apache/solr/pull/4684#discussion_r3687364952
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -357,18 +438,19 @@ private void checkSecurityJsonExists(SolrZkClient
zkClient)
}
}
- private void clearSecurityJson(CommandLine cli, boolean
updateIncludeFileOnly) throws Exception {
+ private void clearSecurityJson(boolean updateIncludeFileOnly,
Callable<String> zkHostResolver)
Review Comment:
Good instinct — the `Callable` wasn't needed. I've reworked it so the ZK
host is resolved once per entry point (skipped with
`--update-include-file-only`) and passed as a plain nullable `String zkHost`
inside the `AuthParams` record; the existing null checks report errors exactly
where they did before.
I also rewrote the branch into two commits: a pure parser-independent
refactor of `AuthTool` (no picocli), and the picocli layer on top. The refactor
commit is up as its own PR against main: #4688 — it can land there
independently of this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
