epugh commented on code in PR #4684:
URL: https://github.com/apache/solr/pull/4684#discussion_r3690835788
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -357,18 +438,19 @@ private void checkSecurityJsonExists(SolrZkClient
zkClient)
}
}
- private void clearSecurityJson(CommandLine cli, boolean
updateIncludeFileOnly) throws Exception {
+ private void clearSecurityJson(boolean updateIncludeFileOnly,
Callable<String> zkHostResolver)
Review Comment:
thanks for this... In some code bases Callables are everywhere, and it
makes sense and you grok it, but in ours, we don't really do that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
