gerlowskija commented on code in PR #4731:
URL: https://github.com/apache/solr/pull/4731#discussion_r3776325689
##########
solr/core/src/test/org/apache/solr/MinimalSchemaTest.java:
##########
@@ -111,11 +110,12 @@ public void testAllConfiguredHandlers() {
assertQ(
"failure w/handler: '" + handler + "'",
- req(
- "qt", handler,
- // this should be fairly innocuous for any type of query
- "q", "foo:bar",
- "omitHeader", "false"),
+ reqWithPath(
+ handler, // this should be fairly innocuous for any type of
query
Review Comment:
I don't love the use of "handler" as it's very v1 specific and a bit
vestigial. But I think there is a bit of a difference in terms of how we use
it colloquially: I think most folks use "Handler" to refer specifically to the
last path-segment (i.e. `/export`) and "path" to talk about the whole path
(i.e. `/solr/collection1/export`).
It'd be nice if we had a v1/v2 agnostic name for "that part of the path that
comes after the collection/core name", but right now I think "handler" is
kindof serving that role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
