gerlowskija commented on code in PR #4731:
URL: https://github.com/apache/solr/pull/4731#discussion_r3784769019
##########
solr/core/src/test/org/apache/solr/DisMaxRequestHandlerTest.java:
##########
@@ -137,19 +137,18 @@ public void doTestSomeStuff(final String qt) {
assertQ(
"boost query",
- req("q", "cool stuff", "qt", qt, "bq", "subject:hell^400"),
+ reqWithPath(qt, "q", "cool stuff", "bq", "subject:hell^400"),
"//*[@numFound='3']",
"//result/doc[1]/str[@name='id'][.='666']",
"//result/doc[2]/str[@name='id'][.='42']",
"//result/doc[3]/str[@name='id'][.='8675309']");
assertQ(
"multi boost query",
- req(
+ reqWithPath(
+ qt,
Review Comment:
Absolutely - that's my aim too. For me it's only a question of "this PR, or
some other one".
I've griped a lot lately about how review-blocked every effort is these days
now that Claude or whatever LLM has made the actual code-generation easier.
And so I've been trying to think through: "This is going to be an absolute ton
of changes; how do I structure that across multiple PRs to shrink as much as
possible the time folks would need to spend in review".
Extremely homogeneous PRs were my attempt at that, but it sounds like you're
OK with loosening that a bit in order to cover more ground in fewer PRs, which
I get. Will update this shortly 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
