dsmiley commented on code in PR #4731:
URL: https://github.com/apache/solr/pull/4731#discussion_r3789373673
##########
solr/core/src/test/org/apache/solr/MinimalSchemaTest.java:
##########
@@ -111,11 +110,12 @@ public void testAllConfiguredHandlers() {
assertQ(
"failure w/handler: '" + handler + "'",
- req(
- "qt", handler,
- // this should be fairly innocuous for any type of query
- "q", "foo:bar",
- "omitHeader", "false"),
+ reqWithPath(
+ handler, // this should be fairly innocuous for any type of
query
Review Comment:
agree with Jason.
##########
solr/core/src/test/org/apache/solr/core/AlternateDirectoryTest.java:
##########
@@ -33,7 +33,7 @@ public static void beforeClass() throws Exception {
}
public void testAltDirectoryUsed() {
- assertQ(req("q", "*:*", "qt", "/select"));
+ assertQ(reqWithPath("/select", "q", "*:*"));
Review Comment:
A point I want to re-raise from my last code review (round 3) that you
didn't seem to notice. I was recommending we use `params(...)`. What I didn't
say explicitly but should have, is that embracing that would mean _not_ having
reqWithPath's method Signature of `(String, String...`) which is kinda
confusing and less typed than a proposed method of simply `req(String,
SolrParams)`.
Any way, no big deal; small matter of taste.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
