janhoy commented on code in PR #4763: URL: https://github.com/apache/solr/pull/4763#discussion_r3819289130
########## changelog/unreleased/SOLR-18374-remove-namedlistentry-and-scope-mapwritermap.yml: ########## Review Comment: I think it’s ok with changelog for removed code, especially when work is done by non committer contributors. Not worth mentioning on RefGuide upgrade notes for sure. But just because there are many removals done in one release does not disqualify adding changelogs IMO. The exception is deprecation removals in pure Unit test code or in non-public APIs or something super minor like removing an unused public constant - not worthy of a changelog. This is judgement and taste. But for external contributions I think there should be a low var for changelog, if just to carry the attribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
