janhoy commented on code in PR #4763: URL: https://github.com/apache/solr/pull/4763#discussion_r3820440922
########## changelog/unreleased/SOLR-18374-remove-namedlistentry-and-scope-mapwritermap.yml: ########## Review Comment: Don't take my word as law here. Different committers will have different views on this issue, I expressed mine. We have not recorded a common written policy on this, it is more just conventions that are somewhat in flux, and at the end of the day the Release Manager for a release has the power to add/delete/merge/tweak changelog entries for that release. I think a guiding principle would be to put yourself in the shoes of an end-user or developer reading the changelog to discover what changed. Our changelog entries should be relevant and understandable for those users. If a certain large feature lands across multiple PRs or JIRAs before a release, they should share one changelog entry for that feature rather than appear as individual efforts. Likewise, if I discover a bug on main and it affects non-released code, there should NOT be a "fixed" changelog, since end users will not percieve it as fixing anything they already have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
