serhiy-bzhezytskyy commented on code in PR #4763: URL: https://github.com/apache/solr/pull/4763#discussion_r3820059693
########## changelog/unreleased/SOLR-18374-remove-namedlistentry-and-scope-mapwritermap.yml: ########## Review Comment: Thanks both for the criteria -- much more actionable than a blanket rule. Checking it against this PR: `NamedListEntry` was a public class called from 4 production files, not test-only/non-public/a trivial constant, so it doesn't match any of the three exceptions -- looks like this one probably should keep its changelog entry after all. I'll restore it here and use the three-exception test for the rest of the batch going forward, rather than dropping changelogs across the board. Also on CI: confirmed the changelog check itself needed a maintainer to manually approve the workflow run before it could even start. Is that expected on every push from an outside contributor, or is there a setting that lets it run automatically after the first approval? AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
