dsmiley commented on code in PR #4761:
URL: https://github.com/apache/solr/pull/4761#discussion_r3846164108
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -1282,6 +1280,11 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest
sreq) {
}
}
+ protected static void updateResponseHeader(NamedList<Object> header, String
key, Object value) {
+ header.remove(key);
+ header.add(key, value);
+ }
+
Review Comment:
Sigh... that really sucks because we're IMO making the code worse on the
account of a test matter. I wonder how easy it might be to "just" change the
return types of SolrQueryResponse in its own PR separately from this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
