serhiy-bzhezytskyy opened a new pull request, #4762: URL: https://github.com/apache/solr/pull/4762
Removes `CloudSolrClient.connect()`/`connect(long, TimeUnit)`, `ClusterStateProvider.connect()`, and the legacy `Builder(List<String>, Optional<String>)` — 54 call sites. `connect()` was never substantive in any implementation (one was literally `getLiveNodes();`); callers now call `getClusterStateProvider().getLiveNodes()` directly. `getClusterState()` is left alone, per the ticket's own note that its future is undecided. Where to look: the `Builder(List, Optional)` → `Builder(String)` swap is not a pure rename — the connection-string parser takes everything after the first `/` as the chroot, which the two-arg form discarded. `RunExampleTool` picks up a real fix from this (its `zkHost` can carry a chroot). Two risks no compiler would catch, both fixed: a mock returning `null` from `getClusterStateProvider()` turned a passing test into a 150s hang instead of a failure (`SolrMessageProcessorTest`, now stubs the provider); and a broken `var` initializer on one line silently swallowed the compile error on the next (`TestSimplePropagatorDistributedTracing`). 54 call sites, 19 changed test classes (one @Ignore'd abstract base correctly has no tests of its own — its 3 concrete subclasses do), compile + gates clean. SOLR-18373, SOLR-18378, SOLR-18382 and SOLR-18386 touch files this PR also touches — merging this one first should make those cleaner to extract. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
