dsmiley commented on code in PR #4768:
URL: https://github.com/apache/solr/pull/4768#discussion_r3848013744
##########
solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java:
##########
Review Comment:
looking at this, it's apparent the logic should be simplified to only get
the list of replicas on this node for the collection the test cares about. No
need for a Map; only a List. Could build in a single Stream.
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##########
@@ -225,7 +208,7 @@ public static ClusterState createFromJson(
return createFromCollectionMap(version, stateMap, liveNodes, creationTime,
prsSupplier);
}
- @Deprecated
+ /** Still used by {@link #createFromJson}. */
Review Comment:
createFromJson has been removed. We can remove this one. Ideally should
have folded both together into the same change to tackle ClusterState API IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
