serhiy-bzhezytskyy commented on code in PR #4768:
URL: https://github.com/apache/solr/pull/4768#discussion_r3854511807
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##########
@@ -225,7 +208,7 @@ public static ClusterState createFromJson(
return createFromCollectionMap(version, stateMap, liveNodes, creationTime,
prsSupplier);
}
- @Deprecated
+ /** Still used by {@link #createFromJson}. */
Review Comment:
Checked — it has its own independent callers (`BackupManager`,
`DistributedClusterStateUpdater`, `ZkStateReader` in production, plus 4 test
files), unrelated to `createFromJson`. Can't remove it; `createFromJson` was
just a thin wrapper over it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
