serhiy-bzhezytskyy commented on PR #4768: URL: https://github.com/apache/solr/pull/4768#issuecomment-5406887141
Both addressed. Rebased on main (`createFromJson` is gone there per SOLR-18149/#4777, so dropped the now-dead method + the stale "Still used by createFromJson" comment). `ZkControllerTest` now does `clusterState.getCollection(collectionName).getReplicasOnNode(nodeName)` directly instead of building a `Map` over every collection -- ran `testPublishAndWaitForDownStates` locally, still passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
