dsmiley commented on code in PR #5049:
URL: https://github.com/apache/solr/pull/5049#discussion_r4223300045
##########
gradle/documentation/javadoc-search.gradle:
##########
Review Comment:
this is a new gradle file; let's do Kotlin; ehh?
##########
gradle/documentation/markdown.gradle:
##########
@@ -63,27 +74,179 @@ configure(project(':solr:documentation')) {
outputFile = file("${project.docroot}/index.html")
templateFile = file("${project.markdownSrc}/index.template.md")
+ logoFile = project.logoAsset
+ heading = 'Documentation'
+ // The index is the Docs landing page, so it only links out to the website.
+ navLinks = ['Home': project.solrHomeUrl]
// list all properties used by the template here to allow uptodate checks
to be correct:
inputs.property('version', project.version)
inputs.property('solrRefguideUrl', project.solrRefguideUrl)
inputs.property('luceneDocUrl', project.luceneDocUrl)
+ inputs.property('luceneDocVersion', project.luceneDocVersion)
+ }
+
+ task createJavadocsIndex(type: MarkdownTemplateTask) {
+ dependsOn markdownToHtml
+ outputFile = file("${project.docroot}/javadocs.html")
+ templateFile = file("${project.markdownSrc}/javadocs.template.md")
+ logoFile = project.logoAsset
+ heading = 'Javadocs'
+ // The masthead already names the page, so the body carries no <h1>.
+ pageTitle = 'Solr Javadocs'
+ navLinks = ['Home': project.solrHomeUrl, 'Docs': 'index.html']
+
+ // list all properties used by the template here to allow uptodate checks
to be correct:
withProjectList()
}
}
+// Renders the page chrome shared by every generated documentation page: the
Review Comment:
this line reads like like something in a 1:1 with claude; not like
documentation here for posterity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
